feat: ability to set resource labels from a workflow #659
+116
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability for workflows to set labels on the resource by writing to /kratix/metadata/labels.yaml. The labels are merged with existing resource labels after the pipeline completes. - Add MergeLabels function to merge incoming labels with existing labels - Modify update-status command to also handle labels.yaml - Update SDK contract with WriteLabels and ReadLabels functions - Add tests for label merging functionality Fixes syntasso#617 Signed-off-by: majiayu000 <1835304752@qq.com>
|
|
Contributor
|
Hi @majiayu000 can you sign the CLA before we review your PRs. |
Author
Thanks for your reminder!!~ |
Contributor
|
Thank you for the contribution, but this doesn't reflect the design direction we're looking for, by adding new files between pipeline stages. We're not looking for improvements in this area at the moment, so I'll remove the good-first-issue label as I think this needs some further discussions internally on how to deliver this and close your PR, but thanks again for the submission! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617
Changes